Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Julia 1.6. #451

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Drop support for Julia 1.6. #451

merged 2 commits into from
Nov 16, 2024

Conversation

evetion
Copy link
Collaborator

@evetion evetion commented Nov 15, 2024

As 1.10 is the new LTS, and 1.6 gives failures.

@evetion evetion changed the title Drop support for 1.6. Drop support for Julia 1.6. Nov 15, 2024
felixcremer
felixcremer reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@felixcremer felixcremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but for the future we could directly use lts in the github workflows so that it would always test on the current lts version.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
rafaqz
rafaqz previously approved these changes Nov 15, 2024
View reviewed changes
@yeesian yeesian merged commit 4f7a7d6 into master Nov 16, 2024
10 of 11 checks passed
@yeesian yeesian deleted the feat/use-lts branch November 16, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixcremer felixcremer felixcremer left review comments

@yeesian yeesian yeesian approved these changes

@rafaqz rafaqz rafaqz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evetion @yeesian @rafaqz @felixcremer