Simplify tests

src/ArchGDAL.jl

@@ -32,6 +32,7 @@ include("ogr/featuredefn.jl")
 include("ogr/fielddefn.jl")
 include("ogr/styletable.jl")
 include("mdarray/types.jl")
+include("mdarray/dimension.jl")
 include("mdarray/global.jl")
 include("mdarray/group.jl")
 include("mdarray/mdarray.jl")

src/context.jl

@@ -241,6 +241,7 @@ for gdalfunc in (
     :getgeom,
     :getgridded,
     :getindex,
+    :getindexingvariable,
     :getlayer,
     :getmask,
     :getmaskband,
@@ -265,7 +266,7 @@ for gdalfunc in (
     :newspatialref,
     :nextfeature,
     :open,
-    # :opendimensionfromfullname,
+    :opendimensionfromfullname,
     :opengroup,
     :opengroupfromfullname,
     :openmdarray,

src/mdarray/dimension.jl

@@ -0,0 +1,57 @@
+# GDALDimension
+
+function getname(dimension::AbstractDimension)::AbstractString
+    @assert !isnull(dimension)
+    return GDAL.gdaldimensiongetname(dimension)
+end
+
+function getfullname(dimension::AbstractDimension)::AbstractString
+    @assert !isnull(dimension)
+    return GDAL.gdaldimensiongetfullname(dimension)
+end
+
+function gettype(dimension::AbstractDimension)::AbstractString
+    @assert !isnull(dimension)
+    return GDAL.gdaldimensiongettype(dimension)
+end
+
+function getdirection(dimension::AbstractDimension)::AbstractString
+    @assert !isnull(dimension)
+    return GDAL.gdaldimensiongetdirection(dimension)
+end
+
+function getsize(dimension::AbstractDimension)::Int
+    @assert !isnull(dimension)
+    return Int(GDAL.gdaldimensiongetsize(dimension))
+end
+
+function unsafe_getindexingvariable(
+    dimension::AbstractDimension,
+)::AbstractMDArray
+    @assert !isnull(dimension)
+    return MDArray(
+        GDAL.gdaldimensiongetindexingvariable(dimension),
+        dimension.dataset.value,
+    )
+end
+
+function getindexingvariable(dimension::AbstractDimension)::AbstractMDArray
+    @assert !isnull(dimension)
+    return IMDArray(
+        GDAL.gdaldimensiongetindexingvariable(dimension),
+        dimension.dataset.value,
+    )
+end
+
+function setindexingvariable!(
+    dimension::AbstractDimension,
+    indexingvariable::AbstractMDArray,
+)::Bool
+    @assert !isnull(dimension)
+    return GDAL.gdaldimensionsetindexingvariable(dimension, indexingvariable)
+end
+
+function rename!(dimension::AbstractDimension, newname::AbstractString)::Bool
+    @assert !isnull(dimension)
+    return GDAL.gdaldimensionrename(dimension, newname)
+end

src/mdarray/global.jl

@@ -5,6 +5,8 @@ function unsafe_createmultidimensional(
     name::AbstractString,
     rootgroupoptions::OptionList = nothing,
     options::OptionList = nothing,
+    ;
+    hard_close::Bool = true,
 )::AbstractDataset
     @assert !isnull(driver)
     return Dataset(
@@ -14,7 +16,7 @@ function unsafe_createmultidimensional(
             CSLConstListWrapper(rootgroupoptions),
             CSLConstListWrapper(options),
         ),
-        hard_close = true,
+        hard_close = hard_close,
     )
 end
 
@@ -23,6 +25,8 @@ function createmultidimensional(
     name::AbstractString,
     rootgroupoptions::OptionList = nothing,
     options::OptionList = nothing,
+    ;
+    hard_close::Bool = true,
 )::AbstractDataset
     @assert !isnull(driver)
     return IDataset(
@@ -32,7 +36,7 @@ function createmultidimensional(
             CSLConstListWrapper(rootgroupoptions),
             CSLConstListWrapper(options),
         ),
-        hard_close = true,
+        hard_close = hard_close,
     )
 end
 
@@ -42,10 +46,14 @@ function unsafe_open(
     alloweddrivers::OptionList,
     openoptions::OptionList,
     siblingfiles::OptionList,
+    hard_close::Union{Nothing,Bool} = nothing,
 )::AbstractDataset
-    # We hard-close the dataset if it is a writable multidim dataset
-    want_hard_close =
-        (openflags & OF_MULTIDIM_RASTER != 0) && (openflags & OF_UPDATE != 0)
+    if hard_close === nothing
+        # We hard-close the dataset if it is a writable multidim dataset
+        hard_close =
+            (openflags & OF_MULTIDIM_RASTER != 0) &&
+            (openflags & OF_UPDATE != 0)
+    end
     return Dataset(
         GDAL.gdalopenex(
             filename,
@@ -54,7 +62,7 @@ function unsafe_open(
             CSLConstListWrapper(openoptions),
             CSLConstListWrapper(siblingfiles),
         ),
-        hard_close = want_hard_close,
+        hard_close = hard_close,
     )
 end
 
@@ -64,10 +72,14 @@ function open(
     alloweddrivers::OptionList,
     openoptions::OptionList,
     siblingfiles::OptionList,
+    hard_close::Union{Nothing,Bool} = nothing,
 )::AbstractDataset
-    # We hard-close the dataset if it is a writable multidim dataset
-    want_hard_close =
-        (openflags & OF_MULTIDIM_RASTER != 0) && (openflags & OF_UPDATE != 0)
+    if hard_close === nothing
+        # We hard-close the dataset if it is a writable multidim dataset
+        hard_close =
+            (openflags & OF_MULTIDIM_RASTER != 0) &&
+            (openflags & OF_UPDATE != 0)
+    end
     return IDataset(
         GDAL.gdalopenex(
             filename,
@@ -76,7 +88,7 @@ function open(
             CSLConstListWrapper(openoptions),
             CSLConstListWrapper(siblingfiles),
         ),
-        hard_close = want_hard_close,
+        hard_close = hard_close,
     )
 end