updgrade to @material-ui #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, forgot to mention it fixes server rendering, which is broken in the current version |
|
Ok, so I just rewrote the whole thing, because react-autosuggest was misbehaving, not giving me the search results right away, and I couldn't find any setting for this. Everything is working for me with this push though. I also added where the user can control the value if he/she wants to outside of the component, so he can clear the results after a suggestion is selected. I updated the docs, but did not code shift or rewrite tests...can do this eventually if needed though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least a starting point for #11. I've verified the code works in my project, but I haven't tested this actual version when I transferred it to this package, so there might be a bug or two, and I didn't update the tests at all.
taken mostly from @ferarnoled's code in #11