Skip to content

Use our common pretty table (#17333) #19887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

eivanov89
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link

🟢 2025-06-19 10:15:13 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the TPCC runner to use our common pretty table for transaction statistics and streamlines output formatting.

  • Refactored PrintTransactionStatisticsPretty to use IOutputStream and NConsoleClient::TPrettyTable
  • Unified console output by replacing std::cout with custom stream components (Cout, Endl)
  • Adjusted newline formatting in text mode display for improved consistency
Comments suppressed due to low confidence (1)

ydb/library/workload/tpcc/runner.cpp:478

  • [nitpick] The removal of extra newline characters in the text mode header may affect the expected layout; verify that the updated output meets the intended formatting requirements.
    ss << data.Phase << " - " << data.ElapsedMinutes << ":"

Copy link

github-actions bot commented Jun 19, 2025

2025-06-19 10:18:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for ef9a0ed has started.
2025-06-19 10:18:41 UTC Artifacts will be uploaded here
2025-06-19 10:21:11 UTC ya make is running...
🟢 2025-06-19 10:39:18 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2198 2188 0 0 3 7

🟢 2025-06-19 10:39:35 UTC Build successful.
🟢 2025-06-19 10:39:47 UTC ydbd size 2.2 GiB changed* by +5.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9543c8e merge: ef9a0ed diff diff %
ydbd size 2 375 953 376 Bytes 2 375 959 424 Bytes +5.9 KiB +0.000%
ydbd stripped size 497 918 408 Bytes 497 919 624 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 19, 2025

2025-06-19 10:19:43 UTC Pre-commit check linux-x86_64-release-asan for ef9a0ed has started.
2025-06-19 10:19:56 UTC Artifacts will be uploaded here
2025-06-19 10:22:28 UTC ya make is running...
🟡 2025-06-19 11:03:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1422 1301 0 12 104 5

2025-06-19 11:03:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-19 11:26:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
243 (only retried tests) 127 0 9 101 6

2025-06-19 11:27:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-19 11:49:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
202 (only retried tests) 143 0 8 45 6

🟢 2025-06-19 11:49:13 UTC Build successful.
🟢 2025-06-19 11:49:29 UTC ydbd size 3.9 GiB changed* by +9.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9543c8e merge: ef9a0ed diff diff %
ydbd size 4 179 402 344 Bytes 4 179 411 560 Bytes +9.0 KiB +0.000%
ydbd stripped size 1 448 933 496 Bytes 1 448 936 248 Bytes +2.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@eivanov89 eivanov89 enabled auto-merge (squash) June 19, 2025 10:33
@eivanov89 eivanov89 merged commit 24688a8 into ydb-platform:main Jun 19, 2025
14 checks passed
@eivanov89 eivanov89 deleted the pretty-print-tpcc-tables branch June 20, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants