-
Notifications
You must be signed in to change notification settings - Fork 694
Use our common pretty table (#17333) #19887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use our common pretty table (#17333) #19887
Conversation
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the TPCC runner to use our common pretty table for transaction statistics and streamlines output formatting.
- Refactored PrintTransactionStatisticsPretty to use IOutputStream and NConsoleClient::TPrettyTable
- Unified console output by replacing std::cout with custom stream components (Cout, Endl)
- Adjusted newline formatting in text mode display for improved consistency
Comments suppressed due to low confidence (1)
ydb/library/workload/tpcc/runner.cpp:478
- [nitpick] The removal of extra newline characters in the text mode header may affect the expected layout; verify that the updated output meets the intended formatting requirements.
ss << data.Phase << " - " << data.ElapsedMinutes << ":"
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...