Skip to content

TPC-C ui/text cleanup (#17333) #19662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

Conversation

eivanov89
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Cleans up and standardizes UI text and formatting for the TPC-C runner’s console and TUI outputs, and refines the pretty-printed transaction statistics.

  • Consolidate dual headers into a single threadsHeader in UpdateDisplayTextMode, simplifying width calculations.
  • Rename and reformat UI elements in UpdateDisplayTuiMode, adjust alignments, and replace raw boxes with window wrappers.
  • Refactor PrintTransactionStatisticsPretty to conditionally include UserAborted based on Config.ExtendedStats, and align columns uniformly.
Comments suppressed due to low confidence (2)

ydb/library/workload/tpcc/runner.cpp:481

  • [nitpick] The name threadsHeader is reused for both left and right columns; consider renaming to a more generic name like columnHeader or statsHeader for clarity.
std::stringstream threadsHeader;

ydb/library/workload/tpcc/runner.cpp:554

  • [nitpick] The static header text Result preview may not clearly convey what metrics are shown; consider using a more descriptive title or restoring dynamic context (e.g. runner name and warehouse count).
headerSs << "Result preview";

Copy link

🟢 2025-06-13 15:35:32 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 13, 2025

2025-06-13 15:35:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0d67a7b has started.
2025-06-13 15:36:03 UTC Artifacts will be uploaded here
2025-06-13 15:38:33 UTC ya make is running...
🟡 2025-06-13 15:57:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2141 2132 0 1 4 4

2025-06-13 15:57:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-13 16:03:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 179 0 0 1 6

🟢 2025-06-13 16:03:48 UTC Build successful.
🟢 2025-06-13 16:03:59 UTC ydbd size 2.2 GiB changed* by -2.7 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9eb7446 merge: 0d67a7b diff diff %
ydbd size 2 369 938 416 Bytes 2 367 145 888 Bytes -2.7 MiB -0.118%
ydbd stripped size 497 058 024 Bytes 496 759 592 Bytes -291.4 KiB -0.060%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 13, 2025

2025-06-13 15:35:55 UTC Pre-commit check linux-x86_64-release-asan for 0d67a7b has started.
2025-06-13 15:36:05 UTC Artifacts will be uploaded here
2025-06-13 15:38:41 UTC ya make is running...
🟡 2025-06-13 16:19:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1367 1290 0 12 61 4

2025-06-13 16:19:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-13 16:42:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 124 0 10 60 4

2025-06-13 16:42:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-13 17:05:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
157 (only retried tests) 128 0 8 17 4

🟢 2025-06-13 17:05:20 UTC Build successful.
🟢 2025-06-13 17:05:37 UTC ydbd size 3.9 GiB changed* by -4.2 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9eb7446 merge: 0d67a7b diff diff %
ydbd size 4 168 084 624 Bytes 4 163 708 616 Bytes -4.2 MiB -0.105%
ydbd stripped size 1 445 815 192 Bytes 1 445 026 168 Bytes -770.5 KiB -0.055%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@eivanov89 eivanov89 merged commit b852e5d into ydb-platform:main Jun 14, 2025
14 checks passed
@eivanov89 eivanov89 deleted the tpcc_tui_cleanup branch June 20, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants