-
Notifications
You must be signed in to change notification settings - Fork 702
TPC-C ui/text cleanup (#17333) #19662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Cleans up and standardizes UI text and formatting for the TPC-C runner’s console and TUI outputs, and refines the pretty-printed transaction statistics.
- Consolidate dual headers into a single
threadsHeader
inUpdateDisplayTextMode
, simplifying width calculations. - Rename and reformat UI elements in
UpdateDisplayTuiMode
, adjust alignments, and replace raw boxes withwindow
wrappers. - Refactor
PrintTransactionStatisticsPretty
to conditionally includeUserAborted
based onConfig.ExtendedStats
, and align columns uniformly.
Comments suppressed due to low confidence (2)
ydb/library/workload/tpcc/runner.cpp:481
- [nitpick] The name
threadsHeader
is reused for both left and right columns; consider renaming to a more generic name likecolumnHeader
orstatsHeader
for clarity.
std::stringstream threadsHeader;
ydb/library/workload/tpcc/runner.cpp:554
- [nitpick] The static header text
Result preview
may not clearly convey what metrics are shown; consider using a more descriptive title or restoring dynamic context (e.g. runner name and warehouse count).
headerSs << "Result preview";
🟢 |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...