Skip to content

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Feb 2, 2026

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.97%. Comparing base (2a93699) to head (80a976e).

Files with missing lines Patch % Lines
...a/tech/ydb/core/impl/pool/NettyChannelFactory.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #580      +/-   ##
============================================
- Coverage     62.98%   62.97%   -0.02%     
- Complexity     2468     2471       +3     
============================================
  Files           333      333              
  Lines         13980    13992      +12     
  Branches       1416     1418       +2     
============================================
+ Hits           8806     8812       +6     
- Misses         4523     4528       +5     
- Partials        651      652       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for custom YDB headers (x-ydb-application-name and x-ydb-client-pid) to enable better tracking and identification of client applications. The implementation refactors metadata interceptor creation into a centralized utility method.

Changes:

  • Added two new optional custom headers: APPLICATION_NAME and CLIENT_PROCESS_ID to the YdbHeaders class
  • Refactored metadata interceptor creation from inline implementation in factory classes to a centralized YdbHeaders.createMetadataInterceptor() method
  • Added builder methods withApplicationName() and withClientProcessId() to GrpcTransportBuilder for configuring the new headers

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
core/src/main/java/tech/ydb/core/grpc/YdbHeaders.java Added new header constants and centralized metadata interceptor creation method
core/src/main/java/tech/ydb/core/grpc/GrpcTransportBuilder.java Added fields, getters, and builder methods for the new custom headers
core/src/main/java/tech/ydb/core/impl/pool/NettyChannelFactory.java Refactored to use centralized metadata interceptor creation, removed duplicate code
core/src/main/java/tech/ydb/core/impl/pool/ShadedNettyChannelFactory.java Refactored to use centralized metadata interceptor creation, removed duplicate code
core/src/test/java/tech/ydb/core/impl/pool/DefaultChannelFactoryTest.java Added test coverage for custom headers and updated existing tests to verify metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alex268 alex268 merged commit ec3e211 into ydb-platform:master Feb 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants