Skip to content

Added support of custom healthcheck to YdbDockerContainer#579

Merged
alex268 merged 1 commit intoydb-platform:masterfrom
alex268:master
Feb 2, 2026
Merged

Added support of custom healthcheck to YdbDockerContainer#579
alex268 merged 1 commit intoydb-platform:masterfrom
alex268:master

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Feb 2, 2026

No description provided.

@alex268 alex268 changed the title Added support of custom healthchech to YdbDockerContainer Added support of custom healthcheck to YdbDockerContainer Feb 2, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.91%. Comparing base (15fd17e) to head (46b2efb).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #579      +/-   ##
============================================
+ Coverage     62.83%   62.91%   +0.08%     
- Complexity     2460     2466       +6     
============================================
  Files           333      333              
  Lines         13975    13980       +5     
  Branches       1415     1416       +1     
============================================
+ Hits           8781     8796      +15     
+ Misses         4542     4533       -9     
+ Partials        652      651       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for custom healthcheck commands to the YdbDockerContainer. The feature allows users to specify a custom command for Docker container health checks via the YDB_DOCKER_HEALTHCHECK environment variable or programmatically through the YdbEnvironmentMock API. When no custom healthcheck is specified (or an empty string is provided), the container falls back to using Docker's built-in healthcheck mechanism.

Changes:

  • Added dockerHealthcheckCmd configuration parameter to YdbEnvironment with support for environment variable YDB_DOCKER_HEALTHCHECK
  • Modified YdbDockerContainer.init() to conditionally use custom healthcheck commands via Wait.forSuccessfulCommand() or default to Wait.forHealthcheck()
  • Added test coverage for the new custom healthcheck functionality

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/common/src/main/java/tech/ydb/test/integration/YdbEnvironment.java Added dockerHealthcheckCmd field and getter method to support custom healthcheck configuration
tests/common/src/test/java/tech/ydb/test/integration/YdbEnvironmentMock.java Added mock support for dockerHealthcheck with setter and override methods
tests/common/src/main/java/tech/ydb/test/integration/docker/YdbDockerContainer.java Implemented conditional logic to use custom healthcheck or default healthcheck based on configuration
tests/common/src/test/java/tech/ydb/test/integration/DockerHelperFactoryTest.java Added new test for custom healthcheck and updated existing tests with additional assertions
tests/common/src/test/java/tech/ydb/test/integration/ProxyDockerTest.java Added assertions to verify null auth token, null pem cert, and disabled TLS
tests/common/pom.xml Configured YDB_DOCKER_REUSE environment variable for test execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alex268 alex268 merged commit 2a93699 into ydb-platform:master Feb 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants