-
Notifications
You must be signed in to change notification settings - Fork 33
455.execute script short api #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_v2.4.0
Are you sure you want to change the base?
455.execute script short api #575
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release_v2.4.0 #575 +/- ##
====================================================
+ Coverage 63.36% 63.54% +0.18%
- Complexity 2493 2529 +36
====================================================
Files 335 342 +7
Lines 13924 14046 +122
Branches 1415 1422 +7
====================================================
+ Hits 8823 8926 +103
- Misses 4465 4473 +8
- Partials 636 647 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * | ||
| * <p>Author: Evgeny Kuvardin | ||
| */ | ||
| public class ScriptClientImpl implements ScriptClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably be the same QueryClient, just another set of methods...
Like in C++ SDK (and API):
https://github.com/ydb-platform/ydb/blob/fe748ee5f76408f9766c8074dca839fa239dc154/ydb/public/sdk/cpp/include/ydb-cpp-sdk/client/query/client.h#L107-L114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a script execution API for YDB Query, enabling asynchronous execution of YQL scripts with support for long-running operations, result fetching, and operation tracking.
Changes:
- Adds ScriptClient interface and implementation for executing YQL scripts asynchronously
- Introduces settings classes (ExecuteScriptSettings, FetchScriptSettings, FindScriptSettings) for configuring script operations
- Provides ScriptResultPart for handling paginated result retrieval
- Includes comprehensive integration tests demonstrating the API usage
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| ScriptClient.java | High-level API interface for script execution with lifecycle management |
| ScriptClientImpl.java | Implementation of ScriptClient using gRPC transport |
| ScriptRpc.java | Low-level RPC interface for QueryService operations |
| ScriptRpcImpl.java | gRPC-based implementation of ScriptRpc |
| ExecuteScriptSettings.java | Configuration for script execution (exec mode, TTL, stats, resource pool) |
| FetchScriptSettings.java | Configuration for result fetching with pagination support |
| FindScriptSettings.java | Settings for retrieving script operation metadata |
| ScriptResultPart.java | Container for partial script results with pagination token |
| ScriptExampleTest.java | Integration tests covering script execution scenarios |
| TestExampleData.java | Visibility change to public for test data reuse |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
query/src/main/java/tech/ydb/query/script/settings/FetchScriptSettings.java
Outdated
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/script/settings/FetchScriptSettings.java
Outdated
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/script/settings/FetchScriptSettings.java
Outdated
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/script/impl/ScriptClientImpl.java
Outdated
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/script/settings/FetchScriptSettings.java
Outdated
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/script/settings/FetchScriptSettings.java
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/script/settings/FetchScriptSettings.java
Outdated
Show resolved
Hide resolved
query/src/main/java/tech/ydb/query/script/impl/ScriptClientImpl.java
Outdated
Show resolved
Hide resolved
738aff2 to
ba63e8b
Compare
ba63e8b to
9c22208
Compare
No description provided.