Skip to content

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Jan 21, 2026

No description provided.

@alex268 alex268 requested a review from pnv1 January 21, 2026 14:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 81.14754% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.54%. Comparing base (4c73f3f) to head (9c22208).

Files with missing lines Patch % Lines
...a/tech/ydb/query/script/impl/ScriptClientImpl.java 67.34% 9 Missing and 7 partials ⚠️
...b/query/script/settings/ExecuteScriptSettings.java 84.00% 4 Missing ⚠️
...ydb/query/script/settings/FetchScriptSettings.java 88.23% 0 Missing and 2 partials ⚠️
...tech/ydb/query/script/result/ScriptResultPart.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release_v2.4.0     #575      +/-   ##
====================================================
+ Coverage             63.36%   63.54%   +0.18%     
- Complexity             2493     2529      +36     
====================================================
  Files                   335      342       +7     
  Lines                 13924    14046     +122     
  Branches               1415     1422       +7     
====================================================
+ Hits                   8823     8926     +103     
- Misses                 4465     4473       +8     
- Partials                636      647      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

*
* <p>Author: Evgeny Kuvardin
*/
public class ScriptClientImpl implements ScriptClient {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably be the same QueryClient, just another set of methods...
Like in C++ SDK (and API):
https://github.com/ydb-platform/ydb/blob/fe748ee5f76408f9766c8074dca839fa239dc154/ydb/public/sdk/cpp/include/ydb-cpp-sdk/client/query/client.h#L107-L114

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a script execution API for YDB Query, enabling asynchronous execution of YQL scripts with support for long-running operations, result fetching, and operation tracking.

Changes:

  • Adds ScriptClient interface and implementation for executing YQL scripts asynchronously
  • Introduces settings classes (ExecuteScriptSettings, FetchScriptSettings, FindScriptSettings) for configuring script operations
  • Provides ScriptResultPart for handling paginated result retrieval
  • Includes comprehensive integration tests demonstrating the API usage

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
ScriptClient.java High-level API interface for script execution with lifecycle management
ScriptClientImpl.java Implementation of ScriptClient using gRPC transport
ScriptRpc.java Low-level RPC interface for QueryService operations
ScriptRpcImpl.java gRPC-based implementation of ScriptRpc
ExecuteScriptSettings.java Configuration for script execution (exec mode, TTL, stats, resource pool)
FetchScriptSettings.java Configuration for result fetching with pagination support
FindScriptSettings.java Settings for retrieving script operation metadata
ScriptResultPart.java Container for partial script results with pagination token
ScriptExampleTest.java Integration tests covering script execution scenarios
TestExampleData.java Visibility change to public for test data reuse

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alex268 alex268 force-pushed the 455.ExecuteScript_short_api branch from 738aff2 to ba63e8b Compare January 27, 2026 12:18
@alex268 alex268 force-pushed the 455.ExecuteScript_short_api branch from ba63e8b to 9c22208 Compare January 27, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants