Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.q3.5 fix #52

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mitchshiotani
Copy link
Contributor

Background

Since support for JDK 11 was removed starting from version 2024.q3,
I tested compilation of dummy-factory using JDK 17 and 21, building for 2024.q3.5.
While there were no issues stemming from the use of JDK 17 & 21,
there were issues from the Java API interface changing again in 2024.q3, which I've fixed in this PR.

Specific fixes

  • Reverted change originally made for 2024.q1.12
  • Had to add an extra argument in places calling _layoutLocalService.addLayout()
  • Added jar build for 2024.q3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants