Cloneable CrawlConfig #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now CrawlConfig is cloneable. It does a deep copy of everything except of DNSResolver and CookieStore, which are shallow copied.
now clone() calls createInstance, so child can overwrite it and call super.clone on their clone methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now CrawlConfig is cloneable. It does a deep copy of everything except of DNSResolver and CookieStore, which are shallow copied.
I've used this to let the user provide a CrawlConfig base config that a crawl controller launcher modifies based on system vars in order to create controllers with different confgurations