Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#358] TEST: improve tests structure #360

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −57
Open

[#358] TEST: improve tests structure #360

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44e3faf
[#$358] $<TEST>:<improve tests structure>
AnnaChupis Jun 19, 2021
0d0bfd7
Delete hidden_element_test.py
AnnaChupis Jun 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[#$358] $<TEST>:<improve tests structure>
@AnnaChupis
AnnaChupis committed Jun 19, 2021
commit 44e3faf3274e20c33e3cbf11f0e8fe46e58e8828
4 changes: 2 additions & 2 deletions tests/integration/condition__browser__have_url_test.py
View file
Original file line number Diff line number Diff line change
@@ -28,6 +28,7 @@

def test_have_url(session_browser):
GivenPage(session_browser.driver).opened_empty()

session_browser.should(have.url(session_browser.driver.current_url))
session_browser.should(
have.no.url(session_browser.driver.current_url[:-1])
@@ -36,13 +37,13 @@ def test_have_url(session_browser):

def test_have_url_containing(session_browser):
GivenPage(session_browser.driver).opened_empty()

session_browser.should(have.url_containing('empty.html'))
session_browser.should(have.no.url_containing('start_page.xhtml'))


def test_fails_on_timeout_during_waiting_for_exact_url(session_browser):
browser = session_browser.with_(timeout=0.1)

GivenPage(browser.driver).opened_empty()

with pytest.raises(TimeoutException) as error:
@@ -53,7 +54,6 @@ def test_fails_on_timeout_during_waiting_for_exact_url(session_browser):

def test_fails_on_timeout_during_waiting_for_part_of_url(session_browser):
browser = session_browser.with_(timeout=0.1)

GivenPage(browser.driver).opened_empty()

with pytest.raises(TimeoutException) as error:
8 changes: 3 additions & 5 deletions tests/integration/hidden_element_test.py
View file
Original file line number Diff line number Diff line change
@@ -31,9 +31,7 @@ def test_should(session_browser):
'''
)

hidden_element = session_browser.element("#hidden")

hidden_element.should(be.in_dom).should(be.hidden)
session_browser.element("#hidden").should(be.in_dom).should(be.hidden)


def test_action_on_element_found_from_hidden_element(session_browser):
@@ -48,8 +46,8 @@ def test_action_on_element_found_from_hidden_element(session_browser):
<h2 id="second">Heading 2</h2>
'''
)
hidden_element = session_browser.element("#hidden")

hidden_element.element('./following-sibling::*/a[2]').click()
session_browser.element("#hidden").\
element('./following-sibling::*/a[2]').click()

assert 'second' in session_browser.driver.current_url