Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs that caused file errors #1151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

exp-3
Copy link

@exp-3 exp-3 commented Feb 22, 2024

  1. Some songs only have plain text lyrics, which were not considered.
  2. Lyrics containing foreign characters would result in a blank file due to a save error.

1. Some songs only have plain text lyrics, which were not considered.
2. Lyrics containing foreign characters would result in a blank file due to a save error.
The titles and artists of some classical music pieces are so long that they result in file paths that are too lengthy to be written.
@exp-3 exp-3 changed the title Fixed two small bugs that could cause lyric files to be blank. Fixed some bugs that caused file errors Feb 23, 2024
@exp-3
Copy link
Author

exp-3 commented Feb 23, 2024

The titles and artists of some classical music pieces are so long that they result in file paths that are too lengthy to be written, so I added some code to forcibly truncate the length of certain strings and file paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant