Removes false positive on non-win32 platforms

yarnpkg · Sep 29, 2021 · 82cc04b · 82cc04b
1 parent 1c92d69
commit 82cc04b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/cli/commands/policies.js b/src/cli/commands/policies.js
@@ -1,4 +1,5 @@
 /* @flow */
+/* eslint-disable max-len */
 
 import type {Reporter} from '../../reporters/index.js';
 import type Config from '../../config.js';

diff --git a/src/util/child.js b/src/util/child.js
@@ -19,16 +19,18 @@ export const exec = promisify(child.exec);
 
 function validate(program: string, opts?: Object = {}) {
   if (program.includes('/')) {
-    return true;
+    return;
   }
 
-  const cwd = opts.cwd || process.cwd();
-  const pathext = process.env.PATHEXT || '';
+  if (process.platform === 'win32' && process.env.PATHEXT) {
+    const cwd = opts.cwd || process.cwd();
+    const pathext = process.env.PATHEXT;
 
-  for (const ext of pathext.split(';')) {
-    const candidate = path.join(cwd, `${program}${ext}`);
-    if (fs.existsSync(candidate)) {
-      throw new Error(`Potentially dangerous call to "${program}" in ${cwd}`);
+    for (const ext of pathext.split(';')) {
+      const candidate = path.join(cwd, `${program}${ext}`);
+      if (fs.existsSync(candidate)) {
+        throw new Error(`Potentially dangerous call to "${program}" in ${cwd}`);
+      }
     }
   }
 }