Core: Use hpagent for proxies #6779
Open
+436
−79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Proxying with the
tunnel
package is... finnicky. I did not extensively investigate these but as a few examples of issues I encountered when I used it in the past:Fixes #6568
Fixes #5244
Hard to tell definitively without reproductions but these should be also fixed:
Fixes #3215
Fixes #2250
How did you fix it?
Use
hpagent
instead. This by itself fixes most HTTPS over HTTP proxying issues.I have also reused HTTPS network settings (e.g. CA certs) for connecting to HTTPS proxies.
Side note:
pem
needs openssl installed to work which makes testing this (and running other HTTPS-related test) difficult in some cases (e.g. on Windows). Should we use another library for HTTPS testing?Checklist