Yarn config respect --no-defaults with --json (fixes #6341)

[sparrowt]

What's the problem this PR addresses?

As documented here https://yarnpkg.com/cli/config you would expect --no-defaults to omit defaults even when --json is also specified.

This PR resolves #6341

How did you fix it?

By respecting noDefaults in the if (this.json) { branch as well as the else

Checklist

• I have read the Contributing Guide.

• I have set the packages that need to be released for my changes to be effective.

• I will check that all automated PR checks pass before the PR gets reviewed.

[arcanis]

That looks good to me; can you also add a test to prevent regressions?

[sparrowt]

I'm new to the repo so will have a look...!

I tried yarn version check --interactive but didn't know what to answer at this point:

[arcanis]

For something like this you'd set both plugin-essentials and cli to patch, and everything else to decline.

[sparrowt]

Re tests it seems https://github.com/yarnpkg/berry/blob/master/packages/acceptance-tests/pkg-tests-specs/sources/commands/config.test.ts is the right place though AFAICS there is no test for --no-defaults at all but I'll have a go

[sparrowt]

Trying to run yarn test:integration config.test.ts even before adding tests, they all fail as follows: (on WSL, node 23.4.0)

Console output

$ yarn test:integration config.test.ts
 FAIL  packages/acceptance-tests/pkg-tests-specs/sources/commands/config.test.ts
  Commands
    config
      ✕ test (folder without rcfile in ancestry / without flags) (277 ms)
      ✕ test (folder without rcfile in ancestry / as json) (2 ms)
      ✕ test (folder with rcfile / without flags) (2 ms)
      ✕ test (folder with rcfile / as json) (2 ms)
      ✕ test (folder with rcfile without trailing newline / without flags) (2 ms)
      ✕ test (folder with rcfile without trailing newline / as json) (2 ms)
      ✕ test (folder with rcfile and rc in parent / without flags) (2 ms)
      ✕ test (folder with rcfile and rc in parent / as json) (2 ms)
      ✕ test (folder with rcfile and rc in ancestor parent / without flags) (2 ms)
      ✕ test (folder with rcfile and rc in ancestor parent / as json) (2 ms)
      ✕ test (folder with rcfile and rc in home folder / without flags) (2 ms)
      ✕ test (folder with rcfile and rc in home folder / as json) (2 ms)

  ● Commands › config › test (folder without rcfile in ancestry / without flags)

    TypeError: Temporary fixture folder: /tmp/xfs-2eb22015/test

    Cannot read properties of undefined (reading 'replace')

      41 | };
      42 |
    > 43 | function cleanupPlainOutput(output: string, path: PortablePath, homePath: PortablePath) {
         |                   ^
      44 |   // Replace multiple consecutive spaces with one space.
      45 |   // The output of the config command is aligned according to the longest value, which probably
      46 |   // contains `path`. In other words, the formatting depends on the length of `path`.

      at cleanupPlainOutput (pkg-tests-specs/sources/commands/config.test.ts:43:19)
      at pkg-tests-specs/sources/commands/config.test.ts:95:20
      at Object.<anonymous> (pkg-tests-core/sources/utils/tests.ts:683:11)

...

what have I missed?

EDIT: ah sorry, I hadn't yet run yarn build:cli (that'll teach me to read more carefully...!)

[sparrowt]

@arcanis hopefully I've done the right thing with committing that releases file.

The tests were gnarly because there was a bunch of dead code which was 'resurrected' by adding a test which returned a single json line - hopefully the commit message explains it sufficiently (!)

[sparrowt]

The 2 CI failures look unrelated, are they a known issue?