Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: e2e - remove npm #4938

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ci: e2e - remove npm #4938

wants to merge 1 commit into from

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Oct 5, 2022 •
edited
Loading

What's the problem this PR addresses?

Some packages invoke npm during the e2e tests which can mess with the results.
https://github.com/yarnpkg/berry/actions/runs/3191301130/jobs/5207447778

How did you fix it?

Remove npm and npx for e2e tests.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz force-pushed the merceyz/ci/e2e-disable-npm branch 2 times, most recently from 18adbbe to f7d54a1 Compare October 5, 2022 19:22
@merceyz merceyz marked this pull request as draft October 5, 2022 22:14
@merceyz merceyz force-pushed the merceyz/ci/e2e-disable-npm branch from f7d54a1 to dd64760 Compare October 30, 2022 12:41
@merceyz merceyz force-pushed the merceyz/ci/e2e-disable-npm branch from dd64760 to 7b5c02b Compare November 27, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merceyz