fixing samtools sort output #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samtools sort was missing the -o argument, which didn't work with current versions of samtools. I believe this fix will work starting with samtools 1.0 forward. May not work with earlier samtools. Could add in a samtools version check.
Author
|
This is my first attempt at contributing to an open source project, so hopefully I am doing it correctly. |
Author
|
So...I had to make a second commit, and have found a potential issue with the test suite. Basically, the output files aren't being cleared. This test has probably been passing even with updated versions of samtools, but when the sort failed, it didn't create a new bam, but the test suite does not clear the existing files, so the tests pass as long as they have passed previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samtools sort was missing the -o argument, which didn't work with current versions of samtools. I believe this fix will work starting with samtools 1.0 forward. May not work with earlier samtools. Could add in a samtools version check.
This resolves Issue 107, and perhaps 91. Has been tested locally.