Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THT Resistor Bands and Vertical #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Electro707
Copy link
Contributor

@Electro707 Electro707 commented Jan 1, 2024

This PR adds a 5-color code bands and a zero/short band to the existing horizontal through-hole resistor models. The 5-color bands or the zero band is displayed by my fork of PCBdraw, see yaqwsx/PcbDraw#156

This change is meant to be backwards compatible with the current implementation of coloring in pcbdraw.

This PR also adds some more resistor sizes, after checking that they are indeed the "bean" type in KiCAD. Proportions are off, so I need to fix that (perhaps even make a new template for those larger sizes)

This PR also adds vertical resistors.

Latest image:
image

TODO:

  • Change the larger size resistors to not look odd, perhaps make a new template for them

@Electro707
Copy link
Contributor Author

image

I think this looks slightly better. Thoughts on improvement? (especially for the taller large ones)

@yaqwsx
Copy link
Owner

yaqwsx commented Jan 30, 2024

I think they look OK. One proposal - maybe adding a gradient to a darker color on one side or a thicker outline could increase the contrast between PCB and the resistor. Especially the resistors without the bands seem to blend with the PCB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants