Update export.py to support 6.99 #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetExcludeEdgeLayer is unavailable in 6.99, add exception escape hatch. The type for the coordinates has changed in 6.99, adapt type to what is used by board.GetDesignSettings().GetAuxOrigin()
|
Hi, thank you for your contribution. However, after the experiences with 5.99, I decided to wait until late fall 2022 until I add support for 6.99. The API changes so fast that any early effort on adopting is only wasted work that often yields clumsy code. I will leave the PR open and I will revisit it when I start adding support for v6.99. |
|
These changes were reflected in #456:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the workflow for fabrication output generation in 6.99.
Version
Application: KiCad Version: (6.99.0-2103-gdc6c27b686), release build Platform: macOS Version 12.4 (Build 21F79), 64 bit, Little endian, wxMacTest Case
kikit fab jlcpcb --no-drc ./Untitled.kicad_pcb ./outIssue 1
SetExcludeEdgeLayer is not available in 6.99.
File "/Applications/KiCad/KiCad.app/Contents/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/kikit/export.py", line 88, in gerberImpl popt.SetExcludeEdgeLayer(settings["ExcludeEdgeLayer"]) AttributeError: 'PCB_PLOT_PARAMS' object has no attribute 'SetExcludeEdgeLayer'Fix is to apply an exception escape hatch as seen in AislerHQ/PushForKiCad#14 (comment)
Issue 2
The type of the aOffset parameter for EXCELLON_WRITER_SetOptions has changed.
/site-packages/pcbnew.py", line 8005, in SetOptions return _pcbnew.EXCELLON_WRITER_SetOptions(self, aMirror, aMinimalHeader, aOffset, aMerge_PTH_NPTH) TypeError: in method 'EXCELLON_WRITER_SetOptions', argument 4 of type 'VECTOR2I const &'Instead of hardcoding the type, use the type returned by
board.GetDesignSettings().GetAuxOrigin()