-
Notifications
You must be signed in to change notification settings - Fork 424
Marcos Huaranga - SOLUTION CHALLENGE #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dimacros
wants to merge
18
commits into
yaperos:main
Choose a base branch
from
dimacros:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated transaction.module-definition.ts to include PrismaService as a provider, allowing for better integration with Prisma options. - Refactored transaction.module.ts to streamline provider registration and ensure PrismaService is correctly injected. - Renamed apps/api to apps/gateway in pnpm-lock.yaml for clarity and consistency. - Updated dependencies in pnpm-lock.yaml to align with the latest versions of NestJS packages and added new apps/processor with necessary dependencies.
…rate PrismaService directly into TransactionModule feat(transaction): update TransactionService to include updateTransactionStatus command and utilize defer for command execution test(transaction): update e2e tests to reference the correct AppModule after transaction.module-definition removal chore(db): add initial migration for Wallet, Transaction, TransactionType, and FraudFlag tables with appropriate constraints and enums fix(prisma): rename TransactionStatus enum to TransactionStatusEnum and update references in Transaction model
…o de base de datos
feat: add TRANSACTION_SERVICE constant for dependency injection feat: create TransactionProxyModule to encapsulate transaction-related services chore: update tsconfig.json to remove baseUrl chore: modify build script in core package.json to include prisma generate refactor: remove deprecated database, fraud, and transaction Kafka config files feat: implement dynamic database module for Prisma client configuration refactor: clean up fraud-proxy module by removing unused adapters refactor: update fraud module to remove CQRS module imports and dependencies feat: enhance transaction commands and handlers for better structure and clarity fix: ensure transaction value is converted to number in PrismaTransactionRepo chore: streamline transaction module by removing unnecessary imports chore: update package.json scripts for better development workflow chore: clean up pnpm workspace configuration chore: add format task to turbo.json for consistent code formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos los detalles se encuentran aqui:
https://github.com/dimacros/app-nodejs-codechallenge/blob/main/CHALLENGE.md
Yape Code Challenge 🚀
Welcome to the Yape Code Challenge! This project is designed to showcase your skills in building scalable, maintainable, and efficient backend systems. The challenge involves implementing a robust microservices architecture using modern tools and frameworks, with a focus on clean code, modular design, and seamless communication between services.
Key Features
Objectives
Technologies Used
Getting Started
Getting started is simple and hassle-free! Follow these steps to spin up the entire system with a single command:
git clone https://github.com/your-repo/yape-code-challenge.git cd yape-code-challenge
This challenge is an excellent opportunity to demonstrate your expertise in backend development, microservices, and event-driven architectures. Good luck, and happy coding! 🚀
cURL Command:
2. Get All Transactions
Description: Retrieves all transactions based on query parameters.
curl -X GET "http://localhost:3000/v1/transactions?page=1&limit=10"
3. Get Transaction by ID
Endpoint:
GET /v1/transactions/:transactionExternalI
Description Retrieves a transaction by its external ID.
cURL Command: