Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types parameter when calling conversations.list api. #65

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

k-sho-boo
Copy link
Contributor

This change should fix issue #63.
conversations.list api gets only public channels is default. I added parameters to get all channels.
This fix works fine on my machine.

@dornela
Copy link

dornela commented Feb 24, 2021

@k-sho-boo I also had to add the parameter limit to fix on my machine. I believe slack api was limiting the number of channels and not bringing the private channels.
$params['limit'] = '999';

@hungri-yeti
Copy link

The commit and the additional suggestion above worked for my local install.

Note: I also needed to do run the --refresh command in the workflow.

Thank you!

@yannickglt yannickglt merged commit 9bdf1b2 into yannickglt:master Mar 17, 2021
@yannickglt
Copy link
Owner

Thanks for your contribution 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants