default to finding tex2svg on user's $PATH #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `tex2svg` is installed in such a way that it is available on `$PATH` (from within emacs), then there's no need for the user to install it manually. I've set the default value of `org-latex-impatient-tex2svg-bin` to simply `tex2svg` (as opposed to the empty string which it was previously set to); this default will work if emacs can find `tex2svg` on the path. I've also updated the documentation to specify that the user *may* need to set the value (since otherwise things may just work). I've also adjusted the documentation to suggest a global installation of `mathjax-node-cli` (and fixed some indentation while I was at it), since IMHO this makes it more likely that `tex2svg` will be on `$PATH` (e.g., on MacOS, if `node` is installed using `homebrew`, then `npm install -g mathjax-node-cli` will put `tex2svg` under `/opt/homebrew/bin/tex2svg`, which is likely to be on `$PATH`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
tex2svgis installed in such a way that it is available on$PATH(from within emacs), then there's no need for the user to install it manually.I've set the default value of
org-latex-impatient-tex2svg-binto simplytex2svg(as opposed to the empty string which it was previously set to); this default will work if emacs can findtex2svgon the path. I've also updated the documentation to specify that the user may need to set the value (since otherwise things may just work). I've also adjusted the documentation to suggest a global installation ofmathjax-node-cli(and fixed some indentation while I was at it), since IMHO this makes it more likely thattex2svgwill be on$PATH(e.g., on MacOS, ifnodeis installed usinghomebrew, thennpm install -g mathjax-node-cliwill puttex2svgunder/opt/homebrew/bin/tex2svg, which is likely to be on$PATH