Fix: treat invalid model with data as valid during view tree creation #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
Author
|
Так, оказывается пока этого не достаточно - есть ещё проверка |
vitkarpov
reviewed
Apr 13, 2017
| * Returns models for view tree. | ||
| * It consists of models and their statuses (ok / error). | ||
| * If any of the models has error status - ns-view-error-content mode will be rendered for that view. | ||
| * @returns {*} |
Member
There was a problem hiding this comment.
Точно returns models? А то эта строчка говорит any (в сам код, без дифа не смотрел, может быть там все правильно)
| // treat model as valid in case | ||
| // - it is really a valid one | ||
| // - it has invalid status but in has real data too (@see #649) | ||
| if (model.isValid() || (model.status === this.STATUS.INVALID && !!model.getData())) { |
Member
There was a problem hiding this comment.
а если зашить это в isValid — страшно (куча мест развалится)?
Member
Author
|
В общем надо думать ещё, давай пока не мёржить, потому что проблема не ушла |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#649