Corrections for TF manifest #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odyvia42
requested changes
Dec 28, 2024
| resource "yandex_iam_service_account" "sa-for-obj-storage" { | ||
| folder_id = local.folder_id | ||
| name = local.os_sa_name | ||
| } | ||
|
|
||
| # Grant the service account storage.admin role to create storages and grant bucket ACLs. | ||
| # Grant the service account storage.admin role to create storages and grant bucket ACLs |
There was a problem hiding this comment.
Suggested change
| # Grant the service account storage.admin role to create storages and grant bucket ACLs | |
| # Grant the service account storage.admin role to manage buckets and grant bucket ACLs |
There was a problem hiding this comment.
Предлагаю здесь поправить.
Роль позволяет не только создавать, но и в целом управлять бакетом, в том числе и удалять его. Ну и термин "бакет" сюда больше подходит, чем хранилище.
| resource "yandex_iam_service_account" "sa-for-obj-storage" { | ||
| folder_id = local.folder_id | ||
| name = local.os_sa_name | ||
| } | ||
|
|
||
| # Grant the service account storage.admin role to create storages and grant bucket ACLs. | ||
| # Grant the service account storage.admin role to create storages and grant bucket ACLs | ||
| resource "yandex_resourcemanager_folder_iam_binding" "s3-editor" { |
There was a problem hiding this comment.
Suggested change
| resource "yandex_resourcemanager_folder_iam_binding" "s3-editor" { | |
| resource "yandex_resourcemanager_folder_iam_binding" "s3-admin" { |
| resource "yandex_storage_bucket" "input-bucket" { | ||
| access_key = yandex_iam_service_account_static_access_key.sa-static-key.access_key | ||
| secret_key = yandex_iam_service_account_static_access_key.sa-static-key.secret_key | ||
| bucket = local.input_bucket | ||
|
|
||
| depends_on = [ | ||
| yandex_resourcemanager_folder_iam_binding.s3-editor |
There was a problem hiding this comment.
Suggested change
| yandex_resourcemanager_folder_iam_binding.s3-editor | |
| yandex_resourcemanager_folder_iam_binding.s3-admin |
| resource "yandex_storage_bucket" "output-bucket" { | ||
| access_key = yandex_iam_service_account_static_access_key.sa-static-key.access_key | ||
| secret_key = yandex_iam_service_account_static_access_key.sa-static-key.secret_key | ||
| bucket = local.output_bucket | ||
|
|
||
| depends_on = [ | ||
| yandex_resourcemanager_folder_iam_binding.s3-editor |
There was a problem hiding this comment.
Suggested change
| yandex_resourcemanager_folder_iam_binding.s3-editor | |
| yandex_resourcemanager_folder_iam_binding.s3-admin |
| @@ -197,7 +212,7 @@ resource "yandex_dataproc_cluster" "dataproc-cluster" { | |||
|
|
|||
| hadoop { | |||
| services = ["HDFS", "SPARK", "YARN"] | |||
| ssh_public_keys = [file(local.dp_ssh_key)] | |||
| ssh_public_keys = ["${file(local.dp_ssh_key)}"] | |||
There was a problem hiding this comment.
Здесь было правильно. Давай вернём как было.
There was a problem hiding this comment.
Тут используется не явно прописанный путь, а локальная переменная, с ней путь нужно записывать именно так
Odyvia42
reviewed
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.