fix(topbar): disallow scope.apply when topbar is not sticky #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are bitten by this quite heavily. @jbrowning any plans to check this (and the pile of other) PR's? If not (and it is perfectly OK!) it would be cool to find a new maintainer or core team. |
feat(dropdown): add top-left align
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?: performance improvement
What is the current behavior?:
I noticed this when I was doing profiling on my application:
Currently if the top bar is not specified as sticky in anyway it still tries to call scope.$apply, which can potentially slow down the application. In my case, the application is relatively large, and the slowness starts to get noticeable.
What is the new behavior?: it doesn't run scope.apply if topBar is not sticky
Does this PR introduce a breaking change?: no
thanks!