Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): added Duration support in Scanner/Valuer #27

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Mar 18, 2024

Fixes

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!

General suggestions:

  • Ensure all upgraded modules are tested thoroughly to prevent any compatibility issues.
  • Consider running a linter to identify any further inconsistencies in code formatting.
  • Review the updated dependency's changelog for any breaking changes or new features that could be leveraged.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 71.41%. Comparing base (572d453) to head (a0d01f3).

Files Patch % Lines
duration.go 70.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   71.43%   71.41%   -0.02%     
==========================================
  Files          36       37       +1     
  Lines        1488     1508      +20     
==========================================
+ Hits         1063     1077      +14     
- Misses        312      317       +5     
- Partials      113      114       +1     
Flag Coverage Δ
Unit-Tests 71.41% <73.91%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

deepsource-io bot commented Mar 18, 2024

Here's the code health analysis summary for commits 572d453..a0d01f3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ Success
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cnlangzi cnlangzi changed the title chore(devops): upgraded go modules feat(db): added Duration support in Scanner/Valuer Mar 18, 2024
@cnlangzi cnlangzi merged commit 8af328c into main Mar 19, 2024
7 checks passed
@cnlangzi cnlangzi deleted the chore/gomod branch March 19, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant