-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db): added Duration
support in Scanner/Valuer
#27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cnlangzi - I've reviewed your changes and they look great!
General suggestions:
- Ensure all upgraded modules are tested thoroughly to prevent any compatibility issues.
- Consider running a linter to identify any further inconsistencies in code formatting.
- Review the updated dependency's changelog for any breaking changes or new features that could be leveraged.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 71.43% 71.41% -0.02%
==========================================
Files 36 37 +1
Lines 1488 1508 +20
==========================================
+ Hits 1063 1077 +14
- Misses 312 317 +5
- Partials 113 114 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Here's the code health analysis summary for commits Analysis Summary
|
Duration
support in Scanner/Valuer
Fixes
Duration
to supportScanner/Valuer
mentioned on add support for time.Duration go-sql-driver/mysql#1217