Change 'click' event into 'mousedown' #1413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the dropdown from closing when the user starts a selection (mousedown) within the input and ends it (mouseup) outside of the input
mouseup event isn't really needed and was causing focus loss when clicking a suggestion
Massi-X
changed the title
|
selection of what? what are the steps to reproduce? a video would be nice :) |
|
Hi @yairEO I can't trigger the bug with unpatched 4.32.1 version, so this could be related to some of my commits in #1410. You could wait to review that but in any case I found this fixes another incorrect behavior (at least to me) that is the border focus style being lost when the selection ends outside the input, see video (for clarity I click the mouse inside the input, drag to select and release it outside of the input borders) 1.mov |
|
Also need to test how this affects mobile users where the |
|
Yep PS. It should be fine https://caniuse.com/?search=mousedown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the dropdown from closing when the user starts a selection (mousedown) within the input and ends it (mouseup) outside of the input