Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Redesign for simpler background thread Model #2408

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

moizarafat
Copy link
Collaborator

Resolves # (if appropriate)

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.


@Override
public Object clone() throws CloneNotSupportedException {
TableExport cloneObj = new TableExport();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to copy result too?


UUID requestId = UUID.fromString(exportObj.getRequestId());

try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be cleaned up since we are restricting async to reads. We don't need to call precommit, or run any lifecycle hooks for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants