Custom classes to scrollbar and thumb elements #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omized offset to scrollbar
| autoUpdate: false, // Autoupdate the scrollbar if DOM changes. Needs MutationObserver or a polyfill to be available | ||
| thumbClass: [], // custom classes to be added to thumb | ||
| scrollbarClass: [], // custom classes to be added to scroll-bar | ||
| scrollBarOffsetTop: 0, //additional offset to position scrollbar |
There was a problem hiding this comment.
Can these offsets not be applied using CSS and the custom classes?
There was a problem hiding this comment.
I see now you're using it in the calculation. Let's modify this to be an object. Like:
scrollbarOffset: {
top: 0,
bottom: 0,
left: 0,
right: 0
}
Also there's a naming inconsistency scrollbarClass vs scrollBarOffset...
There was a problem hiding this comment.
There's css problem with left offset. If applied it messes up position of scrollbar.
I'd apply only top, bottom and right offset, or would not apply any, and leave it to custom class
I did not analyze the code good enough to manipulate offset so easily. Should I just remove offsetting and mark an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the lib is great, but in my project i need funcionality I added. It's just about adding custom classes to thumb and scrollbar elements.