const std::string_view& -> std::string_view

y5nw · Aug 31, 2024 · 311c43d · 311c43d
1 parent 775cab0
commit 311c43d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/client/keycode.cpp b/src/client/keycode.cpp
@@ -260,7 +260,7 @@ static const table_key &lookup_keychar(wchar_t Char)
 	return table.emplace_back(std::move(new_key));
 }
 
-static const table_key &lookup_keyname(const std::string_view &name)
+static const table_key &lookup_keyname(std::string_view name)
 {
 	if (name.empty())
 		return invalid_key;
@@ -297,7 +297,7 @@ static const table_key &lookup_scancode(const u32 scancode)
 	return key.index() == 0 ? lookup_keykey(std::get<irr::EKEY_CODE>(key)) : lookup_keychar(std::get<wchar_t>(key));
 }
 
-KeyPress::KeyPress(const std::string_view &name)
+KeyPress::KeyPress(std::string_view name)
 {
 	if (loadFromScancode(name))
 		return;
@@ -337,7 +337,7 @@ wchar_t KeyPress::getKeychar() const
 	return lookup_scancode(scancode).Char;
 }
 
-bool KeyPress::loadFromScancode(const std::string_view &name)
+bool KeyPress::loadFromScancode(std::string_view name)
 {
 	if (name.size() < 2 || name[0] != '<')
 		return false;

diff --git a/src/client/keycode.h b/src/client/keycode.h
@@ -31,7 +31,7 @@ class KeyPress
 public:
 	KeyPress() {};
 
-	KeyPress(const std::string_view &name);
+	KeyPress(std::string_view name);
 
 	KeyPress(const irr::SEvent::SKeyInput &in) :
 		scancode(in.SystemKeyCode) {};
@@ -61,7 +61,7 @@ class KeyPress
 	static const KeyPress &getSpecialKey(const std::string &name);
 
 private:
-	bool loadFromScancode(const std::string_view &name);
+	bool loadFromScancode(std::string_view name);
 
 	inline std::string formatScancode() const
 	{