Enhance hashmap implementation #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -396,7 +396,8 @@ static int yf_compile_files(struct yf_args * args, struct yf_compilation_data * | |||
| fdata->file_name = yf_strdup(fname); | |||
| fdata->parse_anew = 1; | |||
| /* TODO - more data */ | |||
| yfh_set(&data.files, fdata->file_name, fdata); | |||
| if (yfh_set(&data.files, fdata->file_name, fdata) != YF_OK) | |||
| abort(); | |||
There was a problem hiding this comment.
Could we print some error message here indicating what's happening? Or does abort do something similar?
There was a problem hiding this comment.
Abort lets us break if we're debugging. For a regular user, the error would be meaningless since there's not anything that they can do anything about it.
|
Except for the failing tests. Do we know why? |
|
I'm debugging it |
|
Awesome, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #129 unless I messed up somewhere seriously.