Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for xmltext diff #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stefan-iki
Copy link

Hello,

Thanks for creating and maintaining y-rb project. 👏 I've stumbled upon the same - or similar - problem as described in #155 - in my case however I need to serialize/deserialize from XmlText instead of YText.

Can we copy paste solution from ytext.rs to yxml_text.rs? That's what I did in this pull request. I guess it would serve my needs, although I'm not familiar with rust and yrs/yjs stuff, so... I might have mixed things up. 🤷

What do you think?

Kind regards,

@eliias
Copy link
Collaborator

eliias commented Aug 30, 2024

@stefan-iki Hey… thanks for your contribution. Did the tests pass for you?

@eliias eliias self-assigned this Aug 30, 2024
@stefan-iki
Copy link
Author

Hello @eliias - yes, they have passed for me, but I see now that I've branched off from the last known "green" master revision 58bdaad, not from the top of master (which seems to be "red" now).

By the tests I mean rake spec command.

@eliias
Copy link
Collaborator

eliias commented Aug 30, 2024

Hello @eliias - yes, they have passed for me, but I see now that I've branched off from the last known "green" master revision 58bdaad, not from the top of master (which seems to be "red" now).

By the tests I mean rake spec command.

Ah I see whats going on. There was an accidental merge of a dependabot PR. Let me retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants