XWIKI-22202: Underline inline links on the doc renaming page #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a rule to cover all xHints
surli
added
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22202
Changes
Description
Clarifications
force-underliningclass, contrary to what I assumed would need to be done when reporting this issue. This is nice because the solution is IMO more generic and still correct. This will allow to cover form introduced in non standard extensions properly.Screenshots & Video
Screenshots with the state before the PR can be found on the jira tickets
After this PR:
We can see on those screenshots that the inline links in the forms are correctly underlined.
Executed Tests
Manual testing only (see screenshots above), style change only. Was triggering some accessibility warnings on the CI, but no fails. Should pass them now.
Expected merging strategy