conditional build for addons #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Tyriar
requested changes
Oct 25, 2019
Tyriar
reviewed
Oct 25, 2019
|
Just for reference, an alternative would be lerna: https://github.com/lerna/lerna/tree/master/commands/bootstrap Not sure if it is worth the trouble. |
Co-Authored-By: Daniel Imms <[email protected]>
|
@leomoty Thx for the suggestion. I think we should keep it as simple as possible, to me lerna seems to be overkill here. |
|
@jerch, yeah agreed. |
Tyriar
requested changes
Oct 25, 2019
Tyriar
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #2503 (comment).
This uses a custom addon-install script, that is only present for repo forks (not contained in the npm package). The conditional execution is simply done at package.json level as a
try { require(...) } ...call.@Tyriar:
This works for me, the conditional stuff is merely a hack but should work on all platforms. Did not like the idea to provide different shell scripts here.