Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Phind context and chat history not keeping up with the prompt #1495

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

RasyiidWho
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RasyiidWho,

Thank you for your contribution to the project with the pull request titled "Fix Phind context and chat history not keeping up with the prompt". It's great to see your active involvement in enhancing the functionality of our application.

I will be reviewing your changes and may leave a few comments on the files in the diff. Your efforts in identifying and fixing this issue are much appreciated.

Review Comments

  • The change from "questionHistory" to "question_history" and from "answerHistory" to "answer_history" in Phind.py seems to align better with Python's naming conventions. Good catch!
  • For the modification in the "context" line, you've introduced a one-liner to handle the context from messages with the "system" role. This is a clever approach, ensuring that the context is populated with the latest system message, if available. However, I would recommend adding a comment here for clarity, explaining the logic behind this line for future maintainers.

Again, thanks for your hard work. Looking forward to more of your valuable contributions!

Best regards,
g4f-copilot

@hlohaus hlohaus merged commit 64052f2 into xtekky:main Jan 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants