Add support for ImGui mouse cursors in ImgWindow. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slgoldberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Chris,
This is an implementation to address the "FIXME" request for ImGui mouse-cursor support within ImgWindow.
The change is very straightforward, and works perfectly for the cases I've tested it with.
(I am using this change with my latest upcoming release of A-Better-Camera plugin, v1.5 final, out soon.)
The only complication is of course with XPLM Windows that are "self-decorated" with XPLM handling the resizing (using grab zones on left, right, top, and bottom).
This follows on from additional support added earlier by TwinFan.
I have other changes but I'll send those as separate PRs, since this one is so straightforward and seems to be quite streamlined.
Please let me know if you have any questions or concerns!
Thanks!
Steve
P.S. I've tested this with both the ImGui v1.78 WIP and with the latest ImGui v1.84 WIP.