ENH: include openai-whisper into thirdparty #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingl2k1
reviewed
Sep 5, 2024
Co-authored-by: codingl2k1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openai-whisper requires triton<3 but torch 2.4 requires triton>=3, we have to use torch 2.4 because we need to support all vllm and sglang versions, and in the docker it's already torch 2.4, so the openai-whisper which didn't limit triton version will be found which is a quite old version. The cosyvoice model will fail, actually we introduced openai-whipser for cosyvoice.
Actually openai-whisper can run on triton>=3 but looks like the openai did not want to update it any more, see openai/whisper#2307
Besides this PR uses
nvidia-ml-pyto replacepynvml.Fixes #2195