-
Notifications
You must be signed in to change notification settings - Fork 74
improve nix cache action & add binaries to cache #3020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Claude finished @insipx's task —— View job Code Review Complete ✓Review Checklist:
Review Feedback (2026-01-23, 21:56 UTC)Critical Issue - CI WorkflowRunner mismatch in push-cachix job (.github/workflows/fh-cache.yml:41) The # build job (line 15)
os: [warp-ubuntu-latest-x64-16x, macos-latest]
# push-cachix job (line 41)
os: [warp-ubuntu-latest-x86-16x, macos-latest] # ❌ Should be x64-16xFix: Change line 41 to use Minor Observations
|
Build CI on
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
+ Coverage 73.67% 74.08% +0.41%
==========================================
Files 420 445 +25
Lines 54729 54372 -357
==========================================
- Hits 40319 40279 -40
+ Misses 14410 14093 -317 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2d6e0d8 to
797a63f
Compare
797a63f to
aff7cbe
Compare
a34166d to
832fa55
Compare
fc8841e to
b4f655c
Compare
b4f655c to
875b45e
Compare
this adds the
xdbgandxmtp_clibinaries to https://app.cachix.org/cache/xmtp#pins. building the binaries off main (withnix build .#xdbg) will download the already-built artifact rather than rebuildadds a description to every crate
still need to verify they work (and fixes the broken fh cache on main that's been there for a while) but my
nix flake updateis broken b/c of github outage