Skip to content

Conversation

@insipx
Copy link
Contributor

@insipx insipx commented Jan 15, 2026

this adds the xdbg and xmtp_cli binaries to https://app.cachix.org/cache/xmtp#pins. building the binaries off main (with nix build .#xdbg) will download the already-built artifact rather than rebuild

adds a description to every crate

still need to verify they work (and fixes the broken fh cache on main that's been there for a while) but my nix flake update is broken b/c of github outage

@insipx insipx requested a review from a team as a code owner January 15, 2026 17:32
@claude
Copy link

claude bot commented Jan 15, 2026

Claude finished @insipx's task —— View job


Code Review Complete ✓

Review Checklist:

  • Read and understand the CI workflow changes
  • Review Nix flake configuration updates
  • Review Cargo.toml changes across crates
  • Check for potential issues not already covered
  • Post final review feedback

Review Feedback (2026-01-23, 21:56 UTC)

Critical Issue - CI Workflow

Runner mismatch in push-cachix job (.github/workflows/fh-cache.yml:41)

The build job uses warp-ubuntu-latest-x64-16x but the push-cachix job uses warp-ubuntu-latest-x86-16x (note: x64 vs x86). This means the artifact download will fail because the artifact names won't match.

# build job (line 15)
os: [warp-ubuntu-latest-x64-16x, macos-latest]

# push-cachix job (line 41)  
os: [warp-ubuntu-latest-x86-16x, macos-latest]  # ❌ Should be x64-16x

Fix: Change line 41 to use warp-ubuntu-latest-x64-16x to match the build job.


Minor Observations

  1. Nix configuration looks good: The rust-flake module integration is clean, and the auto-wiring setup with workspace globs is well-structured.

  2. Cargo.toml descriptions: All crates now have descriptions added, which is excellent for documentation and crate publishing.

  3. Fileset management: The nix/lib/filesets.nix uses proper Nix fileset unions and follows good practices for incremental builds.

  4. CI job separation: The split into build → push-cachix → push-flakehub is a good pattern for reliability and only pushing to main.


@macroscopeapp
Copy link
Contributor

macroscopeapp bot commented Jan 15, 2026

Build CI on warp-ubuntu-latest-x64-16x and macos-latest, cache with flakehub-cache-action using https://xmtp.cachix.org, and push binaries to Cachix and FlakeHub from fh-cache.yml

Updates CI to use FlakeHub caching with an upstream Cachix cache, adds a main-branch job that pushes build results to Cachix, and separates FlakeHub publishing into its own job; adjusts Nix flake to nixpkgs-unstable with rust-flake auto-wiring and updates workspace globs in Cargo.

📍Where to Start

Start with the workflow changes in fh-cache.yml, then review Nix flake outputs in flake.nix and Rust auto-wiring in nix/rust-defaults.nix.


Macroscope summarized 875b45e.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.08%. Comparing base (236d4a4) to head (875b45e).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3020      +/-   ##
==========================================
+ Coverage   73.67%   74.08%   +0.41%     
==========================================
  Files         420      445      +25     
  Lines       54729    54372     -357     
==========================================
- Hits        40319    40279      -40     
+ Misses      14410    14093     -317     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@insipx insipx force-pushed the push-pznknkuympxl branch from 2d6e0d8 to 797a63f Compare January 20, 2026 17:57
@insipx insipx requested a review from a team as a code owner January 20, 2026 17:57
@insipx insipx force-pushed the push-pznknkuympxl branch from 797a63f to aff7cbe Compare January 20, 2026 17:58
@insipx insipx force-pushed the push-pznknkuympxl branch 5 times, most recently from a34166d to 832fa55 Compare January 20, 2026 19:06
@insipx insipx force-pushed the push-pznknkuympxl branch 6 times, most recently from fc8841e to b4f655c Compare January 21, 2026 17:58
@insipx insipx force-pushed the push-pznknkuympxl branch from b4f655c to 875b45e Compare January 23, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants