Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SASL2, BIND2, and FAST #1006

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Implement SASL2, BIND2, and FAST #1006

wants to merge 7 commits into from

Conversation

singpolyma
Copy link

No description provided.

@Neustradamus

This comment was marked as off-topic.

Sign in to view
@sonnyp
Copy link
Member

sonnyp commented Dec 16, 2023

Thanks! I will get around to fixing CI and reviewing once I have a bit of time.

@singpolyma
Copy link
Author

Not to be a pain, but any chance to get this looked at? Thanks :)

sonnyp
sonnyp reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for this!

could you add tests? check the other similar modules

e2e tests would be needed as well

CI is broken but I can have a look eventually - let me know if you have troubles running tests locally but a fix would be awesome

@singpolyma
Copy link
Author

@sonnyp tests added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonnyp sonnyp sonnyp left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@singpolyma @Neustradamus @sonnyp