-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Don't link to re-exports from XMonad.Config.Prime #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
I vaguely remember trying this a couple years ago but whatever version of Haddock we were using back then didn't seem to change its behaviour. Does this actually work now? That would be awesome! (But we might need to bump xmonad-docs to a newer version of ghc/haddock) |
I didn't actually try. I just did the edit quickly on GitHub from my mobile device. |
From a cursory local test, seems like this doesn't work :( |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{-# OPTIONS_HADDOCK hide #-}
does the trick.
Seems to work 👍
This has the disadvantage that we lose the documentation of
XMonad.Config.Prime
, but given that it is deprecated I hope this is an easy compromise.
Indeed, a small price to pay
OK, great, from my side this is ready to merge. |
Is there anything else to discuss here? If not, can somebody click the merge button? |
Thanks! |
No description provided.