Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated url literals #904

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

cafkafk
Copy link
Contributor

@cafkafk cafkafk commented Sep 15, 2024

Description

Nix url litterals are being depricated in flake inputs and fails to build on
never versions. I've just quoted them so it keeps building.

Signed-off-by: Christina Sørensen [email protected]

Checklist

  • I've read CONTRIBUTING.md

  • I've considered how to best test these changes (property, unit,
    manually, ...) and concluded: XXX

  • I updated the CHANGES.md file

Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk cafkafk marked this pull request as ready for review September 15, 2024 16:31
@cafkafk
Copy link
Contributor Author

cafkafk commented Sep 15, 2024

I'm making the assumption that no one cares to include this in CHANGES.md, but if people want nix flake fixes in there as well LMK and I'll add a note

@liskin
Copy link
Member

liskin commented Sep 15, 2024

I'm making the assumption that no one cares to include this in CHANGES.md, but if people want nix flake fixes in there as well LMK and I'll add a note

I don't think we distribute the nix stuff in the release tarball so yeah I think it's okay not to mention it in CHANGES

@geekosaur
Copy link
Contributor

We don't.

@geekosaur geekosaur merged commit 4350936 into xmonad:master Sep 15, 2024
20 checks passed
@cafkafk cafkafk deleted the fix-url-litterals branch September 16, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants