X.A.WindowNavigation: better handling of floating windows and Full layout #896
Conversation
XMonad/Actions/WindowNavigation.hs
Outdated
| -- (keeps the position as-is if it is already inside the target rectangle) | ||
| centerPosition :: Rectangle -> Point -> Point | ||
| centerPosition (Rectangle rx ry rw rh) pos@(Point x y) = do | ||
| if x >= rx && x < rx + fromIntegral rw && y >= ry && y < ry + fromIntegral rh |
There was a problem hiding this comment.
We have https://hackage.haskell.org/package/xmonad-0.18.0/docs/XMonad-Operations.html#v:pointWithin, would it be useful here?
There was a problem hiding this comment.
Yes, that's useful, I'll update the code.
| pos = pointTransform dir currentPos | ||
| wr = rectTransform dir currentRect | ||
|
|
||
| rectInside r = (rect_p1 r >= rect_p1 wr && rect_p1 r < rect_p2 wr && rect_p2 r > rect_p1 wr && rect_p2 r <= rect_p2 wr) && |
There was a problem hiding this comment.
There was a problem hiding this comment.
This one is less useful, because it doesn't handle the special case of a window that fully overlaps the current window in the orthogonal direction.
…yout Previous version most of the time just got "stuck" on floating windows, switching back and forth between floating window and tiled window underneath. This was because "magic point" was left in the same position and thus next navigation commands selected the same windows over and over again. Now the "magic point" is moved around such that it doesn't overlap with the previously selected window, and there are more complicated rules to make navigation between floating and tiled windows more natural. The original behavior of navigating between tiled windows is preserved almost precisely. Previous version also prevented switching windows using focusUp/focusDown when in Full layout. Now there's a special case that handles such situations.
Rogach
force-pushed
the
pr/window-navigation
branch
from
3f6e585 to
66d334f
Compare
|
I'm going to wait a few days for one of the other maintainers to look at it, but as they're often unavailable I won't wait too long. |
FWIW I definitely plan to look at this in the coming days |
|
Thanks! |
Description
Previous version of WindowNavigation just got "stuck" on floating windows, switching back and forth between floating window and tiled window underneath. This was because "magic point" was left in the same position and thus next navigation commands selected the same windows over and over again. Now the "magic point" is moved around such that it doesn't overlap with the previously selected window, and there are more complicated rules to make navigation between floating and tiled windows more natural.
The original behavior of navigating between tiled windows is preserved almost precisely (the tree-like layouts - which should be overwhelmingly the most popular ones - will have exactly the same behavior, the only differences might be in some convoluted custom layouts).
Previous version of WindowNavigation also prevented switching windows using focusUp/focusDown when in Full layout. Now there's a special case that handles such situations.
Checklist
CHANGES.mdfile