XMonad.Hooks.ScreenCorners: Add support for edges #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Jun 8, 2024
XMonad/Hooks/ScreenCorners.hs
Outdated
| let w = displayWidth dpy (defaultScreen dpy) - 1 | ||
| h = displayHeight dpy (defaultScreen dpy) - 1 | ||
| threshold = 150 | ||
| in createWindowAtWithWidth threshold (fi h) (fi $ fi w - threshold * 2) |
There was a problem hiding this comment.
Suggested change
| in createWindowAtWithWidth threshold (fi h) (fi $ fi w - threshold * 2) | |
| in createWindowAtWithWidth threshold (fi h) (fi w - fi threshold * 2) |
Previously only corners are supported, now support for edges are added. This is similar to Hot Edge shell extension in GNOME.
|
Hi, I have added support for SCLeft and SCRight, updated the doc and commit message as well. |
geekosaur
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In XMonad.Hooks.ScreenCorners, previously only corner is supported, now support for top and bottom edges is added. This is similar to Hot Edge shell extension in GNOME.
I could add support for SCLeft, SCRight too, if it's desired. I thought I'd ask for a review on this first.
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit,
manually, ...) and concluded:
I updated the
CHANGES.mdfile