-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new module: X.L.CircleEx: advanced version of Circle layout #848
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on a cursory read, this look fine, thanks! 👍
Since you say that this essentially supersedes X.L.Circle, would it be possible to (i) implement that in terms of this new module, and (ii) perhaps deprecate X.L.Circle (if that's desired)?
Ok. For (i), I added a variant of default settings which mimics X.L.Circle's hardcoded settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, just came by to say that a screenshot would be great 😄
@slotThe Now, when I deprecated X.L.Circle module, I see some number of deprecation warnings, since it was used in several places. I think I should also replace Circle with CircleEx in these places. |
Sounds good 👍 |
Done. Please review. |
Thanks! (I just pushed some doc fixes) |
Description
X.L.Circle layout is somewhat nice, but it does not provide much possibilities for customization. This adds a new module, X.L.CircleEx, which is similar to X.L.Circle, but has some new features:
Checklist
I've read CONTRIBUTING.md
I've done extensive manual testing by using it for a month :)
I updated the
CHANGES.md
file