Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for unicode prompt #841

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

jpolchlo
Copy link
Contributor

@jpolchlo jpolchlo commented Nov 7, 2023

Description

This PR adds some additional context regarding the required UnicodeData.txt file needed for the XMonad.Prompt.Unicode module.

Closes #840

Checklist

  • I've read CONTRIBUTING.md

  • I've considered how to best test these changes (property, unit,
    manually, ...) and concluded: there are only documentation changes; no testing required

  • I updated the CHANGES.md file

Copy link
Contributor

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let this sit overnight for further comments and then commit if nobody else has anything to add.

@geekosaur
Copy link
Contributor

Actually, can you shorten the commit title and move the rest into the description? Git prefers a title length less than 50 characters. Also, there should be a blank line between the title and the description.

@jpolchlo jpolchlo changed the title Document the unicode data file required by XMonad.Prompt.Unicode Add documentation for unicode data prompt Nov 7, 2023
@jpolchlo jpolchlo changed the title Add documentation for unicode data prompt Add documentation for unicode prompt Nov 7, 2023
Having this file is required for the prompt to work, and how to obtain
it may not be immediately obvious.
@slotThe slotThe force-pushed the docs/unicode-prompt branch from 832d151 to da566d6 Compare November 8, 2023 09:33
@slotThe slotThe merged commit 8035db1 into xmonad:master Nov 8, 2023
18 checks passed
@slotThe
Copy link
Member

slotThe commented Nov 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify a location to download data for XMonad.Prompt.Unicode
3 participants