-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address some -Wx-Partial
warnings
#836
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reexport them instead.
geekosaur
approved these changes
Oct 15, 2023
Where appropriate.
liskin
reviewed
Oct 15, 2023
liskin
reviewed
Oct 15, 2023
Stolen from X.A.MostRecentlyUsed. This can be used in favour of lists when we know the generated lists are definitely infinite.
This gets rid of, for example, The import of ‘liftA2’ from module ‘XMonad.Prelude’ is redundant -type warnings.
slotThe
added a commit
to slotThe/xmonad-contrib
that referenced
this pull request
Oct 27, 2023
Fixes: xmonad#830 Related: xmonad#836
slotThe
added a commit
to slotThe/xmonad-contrib
that referenced
this pull request
Oct 27, 2023
Fixes: xmonad#830 Related: xmonad#836
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #830
I sort of ran out of steam at some point, but this is a good chunk of them. Most of these are relatively automatic replacements, only 5fc6777 could perhaps use a second pair of eyes, to see whether I've made any illegal transformations.
Commit summary
5fc6777 Reduce head usage
8f735ac Import X.Prelude unqualified if necessary
This gets rid of, for example,
-type warnings.
9399a1e X.{U,H}.Debug{Window,Events}: Replace tail with non-empty listsec3a9ee X.L.Groups: Rewrite gen using infinite streams
3a3544b X.Prelude: Add infinite stream type
Stolen from X.A.MostRecentlyUsed. This can be used in favour of lists
when we know the generated lists are definitely infinite.
fab8ad5 X.U.Stack: Add differentiateTwo
cbb8524 Replace tail with drop 1
Where appropriate.
c8c8147 X.A.CycleWindows: Move rot{Up,Down} to X.A.RotSlaves
Reexport them instead.
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit,
manually, ...) and concluded:
I haven't installed GHC 9.8 (yet), so this is mostly untested. Everything should work, though.
I updated the
CHANGES.md
fileWhere appropriate.
Remaining nits
Remaining nits…