Skip to content

Conversation

SirLynix
Copy link
Member

@SirLynix SirLynix commented Oct 7, 2025

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

Copy link
Contributor

Summary of Changes

Hello @SirLynix, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the build compatibility for the libsdl3_ttf package on Windows by enabling support for long file paths. This modification is crucial for preventing build failures or git clone issues that can occur when repository paths exceed the default Windows path length limits, ensuring a smoother development experience for Windows users.

Highlights

  • Windows Long Paths: Enabled the platform.longpaths policy specifically for Windows hosts within the libsdl3_ttf package configuration. This change addresses potential issues with git clone operations that might encounter path length limitations on Windows.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly enables long path support on Windows for the libsdl3_ttf package, which will resolve potential git clone failures due to path length limits. The change is well-implemented.

My main suggestion is to consider applying this same policy to other packages in the repository that are also fetched via Git (e.g., libsdl3, freetype, harfbuzz, plutosvg), as they are likely susceptible to the same issue on Windows. This would improve the robustness of the build process across the board.

I have also left one comment with a suggestion to add a code comment for better maintainability.

@SirLynix SirLynix marked this pull request as draft October 7, 2025 21:29
@SirLynix
Copy link
Member Author

SirLynix commented Oct 7, 2025

I moved back libsdl3_ttf to .zip because .tar.gz has symlinks that Windows cannot handle without admin

git cloning was failing because of filenames too long for windows (even with longpath) in harbuzz submodule, disabling submodules didn't work because of a bug (see xmake-io/xmake#6901 )

@SirLynix SirLynix marked this pull request as ready for review October 7, 2025 22:10
@SirLynix SirLynix changed the title libsdl3_ttf: enable long path to handle git clone libsdl3_ttf: fix windows download and disable submodules for git clone Oct 7, 2025
@waruqi waruqi merged commit 52b0dee into dev Oct 8, 2025
61 checks passed
@waruqi waruqi deleted the SirLynix-patch-3 branch October 8, 2025 11:47
luadebug pushed a commit to luadebug/xmake-repo that referenced this pull request Oct 9, 2025
xmake-io#8344)

* libsdl3_ttf: enable long path to handle git clone

* Update xmake.lua

* Update xmake.lua

* move back libsdl3_ttf to .zip because of windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants