-
-
Notifications
You must be signed in to change notification settings - Fork 479
libsdl3_ttf: fix windows download and disable submodules for git clone #8344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SirLynix
commented
Oct 7, 2025
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
- 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。
Summary of ChangesHello @SirLynix, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the build compatibility for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly enables long path support on Windows for the libsdl3_ttf
package, which will resolve potential git clone
failures due to path length limits. The change is well-implemented.
My main suggestion is to consider applying this same policy to other packages in the repository that are also fetched via Git (e.g., libsdl3
, freetype
, harfbuzz
, plutosvg
), as they are likely susceptible to the same issue on Windows. This would improve the robustness of the build process across the board.
I have also left one comment with a suggestion to add a code comment for better maintainability.
I moved back libsdl3_ttf to .zip because .tar.gz has symlinks that Windows cannot handle without admin git cloning was failing because of filenames too long for windows (even with longpath) in harbuzz submodule, disabling submodules didn't work because of a bug (see xmake-io/xmake#6901 ) |
xmake-io#8344) * libsdl3_ttf: enable long path to handle git clone * Update xmake.lua * Update xmake.lua * move back libsdl3_ttf to .zip because of windows