-
-
Notifications
You must be signed in to change notification settings - Fork 478
gmp: add windows support #8343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
gmp: add windows support #8343
Conversation
TODO
|
😒 test -n "$DJDIR" || exec 7<&0 </dev/null
exec 6>&1 error: @programdir\core\sandbox\modules\os.lua:273: ./configure: line 603: 0: Bad file descriptor |
/gemini summary |
It looks like you're trying to invoke the |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for building the gmp
library on Windows using MSVC and Clang toolchains. The changes are extensive, involving modifications to the build process, new configurations, and platform-specific workarounds. While the overall approach is sound, I've found several issues, including a critical regression for macOS cross-compilation, some risky flag manipulations that could lead to build failures, and other areas for improvement in terms of robustness and clarity. Please see my detailed comments for suggestions on how to address these points.
Support msvc/clang toolchain build on msys2 or linux + msvc-wine.
Thanks by gpt-5.