-
-
Notifications
You must be signed in to change notification settings - Fork 478
Auto-update scons to 4.10.0 #8336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the latest version of SCons, 4.10.0, into the project's build system. By updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the scons
package to version 4.10.0
. While the version bump itself is straightforward, I've raised a concern about the continued validity of existing patches in the build script for this new version. It's crucial to ensure that these workarounds are still compatible with scons 4.10.0
to prevent potential build issues.
|
||
add_urls("https://github.com/SCons/scons/archive/refs/tags/$(version).zip", | ||
"https://github.com/SCons/scons.git") | ||
add_versions("4.10.0", "2a68298875394fa6665f7ac360c682d846d2bdb786b54b4de785d7bd39c2b79e") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This automated version update introduces a potential issue. The on_install
function contains patches and workarounds specific to older scons
versions (e.g., lines 31-39 and 43). These may be incompatible with version 4.10.0, potentially causing build failures or incorrect behavior. For instance, the patch applied to SCons/Tool/masm.py
on line 43 might not work with the new version. Such patches should be re-validated with each version bump to ensure compatibility.
New version of scons detected (package version: 4.9.1, last github version: 4.10.0)