-
-
Notifications
You must be signed in to change notification settings - Fork 478
Auto-update grpc to v1.75.1 #8335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automatically updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the grpc package to version v1.75.1. The change is correct. However, for better maintainability, I've noticed that the list of versions in packages/g/grpc/xmake.lua
is not sorted. I've added a comment to suggest sorting the versions in descending order, which is a common convention in this repository.
add_urls("https://github.com/grpc/grpc/archive/refs/tags/$(version).zip", | ||
"https://github.com/grpc/grpc.git") | ||
|
||
add_versions("v1.75.1", "d89752e5362c8b3c7583f82c665d22c6f11f9b382c99bc5f8744b54c8c14ce4c") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability, it's good practice to keep the list of versions sorted. The versions in this file are currently out of order. Please sort all add_versions
calls in descending order. Many other package files in this repository follow this convention.
Here is the correctly sorted block:
add_versions("v1.75.1", "d89752e5362c8b3c7583f82c665d22c6f11f9b382c99bc5f8744b54c8c14ce4c")
add_versions("v1.69.0", "987763312292c8a6088108173ccde2b336a40f35ae22b5b7b3744e44929aaf9f")
add_versions("v1.68.2", "2a17adb0d23768413ca85990dbf800a600863d272fcc37a9f67f3b5e34ae9174")
add_versions("v1.62.1", "f672a3a3b370f2853869745110dabfb6c13af93e17ffad4676a0b95b5ec204af")
add_versions("v1.51.3", "17720fd0a690e904a468b4b3dae6fa5ec40b0d1f4d418e2ca092e2f92f06fce0")
New version of grpc detected (package version: v1.69.0, last github version: v1.75.1)